[PATCH] Fail to start ldb if modules are missing
idra at samba.org
Thu Nov 18 06:18:34 MST 2010
On Thu, 2010-11-18 at 14:07 +0100, Stefan (metze) Metzmacher wrote:
> Am 18.11.2010 14:04, schrieb simo:
> > If a module is missing we merrily keep going. This means we can end up
> > corrupting the ldb because maintenance tasks the module is supposed to
> > do are not performed.
> > This patch makes ldb return an error if a requested module is not found.
> Sounds useful, but we should have a force switch so that someone can fix
> the modules list if needed.
> > Sending to the list because it changes behvaior and haven't tested it w/
> > samba4 yet.
> > Tridge,
> > do you think it is ok ?
> Did you want to attach a patch here?
We do not need a force switch, you can pass an explicitly empty module
list at the command line so you can open the ldb w/o modules, and change
the @MODULES attribute. I've done that multiple times in the past while
playing with modules that would crash in the init function :)
Patch sent in the next mail and Tridge acked on IRC.
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical