s3: Quieten a bogus error message

Andrew Bartlett abartlet at samba.org
Tue Nov 9 13:26:01 MST 2010

On Tue, 2010-11-09 at 21:16 +0100, Volker Lendecke wrote:
> The branch, master has been updated
>        via  c83a40d s3: Quieten a bogus error message
>       from  5f37473 s3: Package autorid module
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> - Log -----------------------------------------------------------------
> commit c83a40ddbfe0710b9206f98f811bbf9056870ebe
> Author: Volker Lendecke <vl at samba.org>
> Date:   Tue Nov 9 20:29:17 2010 +0100
>     s3: Quieten a bogus error message
>     This happens if you set "auth methods = winbind" without a fallback method.
>     The return NT_STATUS_LOGON_FAILURE; is not strictly require here, because we
>     fall through to the equivalent statement a few lines down, but it makes the
>     code a bit clearer IMO.
>     Autobuild-User: Volker Lendecke <vlendec at samba.org>
>     Autobuild-Date: Tue Nov  9 20:15:59 UTC 2010 on sn-devel-104

Nice patch!

While I wish users would not set 'auth methods' manually, it is
available and this is a perfectly reasonable syntax.  I agree your patch
is much clearer than just letting it fall down to the default below.

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101110/a62158e1/attachment.pgp>

More information about the samba-technical mailing list