[SCM] Samba Shared Repository - branch master updated

Jelmer Vernooij jelmer at samba.org
Mon Nov 8 05:49:36 MST 2010


On Mon, 2010-11-08 at 12:22 +0100, Matthias Dieter Wallnöfer wrote:
> @@ -1441,7 +1442,13 @@ static int py_ldb_contains(PyLdbObject *self, PyObject *obj)
>  
>  	talloc_free(result);
>  
> -	return count;
> +	if (count == 1) {
> +		return 1;
> +	} else if (count == 0) {
> +		return 0;
> +	}
> +
> +	return -1;
>  }
>  
>  static PySequenceMethods py_ldb_seq = {
^^ This is wrong. This means we'll not set an exception and return -1 if
count is more than one.

As I've said earlier I think the risk of these fixes is higher than the
(purely theoretical) gain. 

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101108/0fa10ab7/attachment.pgp>


More information about the samba-technical mailing list