dns.idl ==> build breaks on non-ipv6 systems

Michael Adam obnox at samba.org
Fri Nov 5 20:05:28 MDT 2010

Hi Kai and list,

it seems the introduction of the dns server in s4
has broken the build on non-ipv6 systems by using
AD_INET6 unconditionally in the pull/push/print_ipv6
functions in ndr_basic.c

Since these functions are in ndr_basic.c this also
breaks the build of s3 on non-ipv6-systems.

Attached find a patch that moves these 3 functions
to a new module ndr_ipv6.c that is only used in s4.
So this fixes the build in s3. Andrew argued that
this is no proper fixing, and he is right, but I
think that these functions deserve their own module
anyways. The s4 case needs fixing, but I would
appreciate if you could push (or ACK) this patch first,

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-librpc-ndr-move-the-ipv6-related-ndr-functions-to-ne.patch
Type: text/x-patch
Size: 5941 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101106/bb7003e0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101106/bb7003e0/attachment.pgp>

More information about the samba-technical mailing list