fix incorrect spoolss GetPrinterData behaviour

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Nov 5 09:36:19 MDT 2010

On Sat, Nov 06, 2010 at 02:25:01AM +1100, David Disseldorp wrote:
> Windows can send spoolss GetPrinterData requests with an offered buffer
> size of zero, Model and TrayFormTable data is commonly requested in
> this way.
> Samba's GetPrinterData response for the above case includes the correct
> error code (WERR_MORE_DATA), however the type field is set to REG_NONE.
> This causes Windows (seen on XP and 2k3) to give up on the request,
> the result of which is an incorrect printer device settings page.
> If the type field is retained (not set to REG_NONE) when responding with
> WERR_MORE_DATA, Windows reissues the GetPrinterData request with an
> increased offered buffer size.
> The following changes since commit
> 169a637a4a3c441aae710f63074106c96e540324:
>   s3: Allow disabling of mdns registrations (2010-11-05 12:38:32 +0100)
> are available in the git repository at:
>   git:// get_printer_data
> David Disseldorp (1):
>       s3-spoolss: fix spoolss GetPrinterData behaviour

While I can't really judge whether this is right (It looks
very compelling), it would be great to also get a torture
test for this.

Günther, where should this be added in the spoolss tests?


More information about the samba-technical mailing list