jra at samba.org
Wed Nov 3 10:04:13 MDT 2010
On Wed, Nov 03, 2010 at 05:01:27PM +0100, Volker Lendecke wrote:
> On Wed, Nov 03, 2010 at 11:58:17AM -0400, simo wrote:
> > > > Shirish, you can fix this probably by #including "stdbool.h"
> > > > before wbclient.h.
> > >
> > > Wasn't bool introduced in C99 ? Do we require C99 ?
> > afaik the answers are yes and yes
> For building libwbclient itself I can see that, as well as
> building for Samba. But the question is: Do we want to
> enforce this on all users of our libraries as well? If so,
> we should #include <stdbool.h> in wbclient.h. If not, we
> should s/bool/int/ in wbclient.h.
> I don't really care how we fix it, I'm asking a technical
> question: Does s/bool/int/ in wbclient.h induce an
> incompatible ABI change, or is bool always represented as an
> int in a function call?
I don't know. I'll check the C99 spec. If it is always int
then we can alias it somewhere for platforms that don't
More information about the samba-technical