In s3compat, to ifdef or not to ifdef, that's the issue

[simo]

On Wed, 2010-05-26 at 11:36 +1000, Andrew Bartlett wrote:
> 
> It would certainly be much easier for me to just #ifdef out the
> functions that I need to replace.  In terms of build systems, it would
> also be easier if I can reuse the samba3 waf rules with just -D and -I
> manipulations.  (ie, add #ifndef ENABLE_S3COMPAT to the files I've
> split
> out). 
> 
> If that is acceptable to the rest of the team, I would like to use
> that
> approach for future changes.  For example, it would be awkward to try
> implement the attached 2 patches any other way.

Apparently there isn't any strong opinion about this.
Given you agree #ifdefs are generally easier I would suggest we go that
route with all patches that have not yet been committed to master.

But a suggestion is as far as I go.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>