Commit 086c6c0e9a56f7e6dca6c1398e210b8c6225e4ed

Björn JACKE bj at SerNet.DE
Wed May 26 14:28:27 MDT 2010


Hi Volker,

the changed version of this commit doesn't do what the previous one did and
breaks some builds like the one on Tru64. In the worst case others might have
silently broken thread support now. The previous version was intended to set
CFLAGS for the compiles of certain object files that need it. Other object
files may not have that CFLAGS, that's why it's not allowed to set them
globally. I know that this was written in a GNU make fashion but we had known
GNU make dependencies also on other places in the past. I'd love to write this
object file based CFLAGS up in a non GNU way but I don't know how. Before we
end up with broken thread support I'd propose to reintroduce the gmake
dependency again (at least for now...).

Cheers
Björn

commit 086c6c0e9a56f7e6dca6c1398e210b8c6225e4ed
Author: Volker Lendecke <vl at samba.org>
Date:   Sat May 22 19:29:13 2010 +0200

    s3: Attempt to fix the non-gnumake build
    
    Björn, please check!

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 81328eb..f5c243f 100644
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -1398,7 +1398,8 @@ wins : SHOWFLAGS @WINBIND_WINS_NSS@
 
 modules:: SHOWFLAGS $(MODULES)
 
-$(LIBSMBCLIENT_THREAD_OBJ) ../nsswitch/wins.o ../nsswitch/winbind_nss_linux.o: EXTRA_FLAGS := $(PTHREAD_CFLAGS)
+$(LIBSMBCLIENT_THREAD_OBJ) ../nsswitch/wins.o \
+       ../nsswitch/winbind_nss_linux.o := EXTRA_FLAGS = $(PTHREAD_CFLAGS)
 
 #####################################################################
 ## Perl IDL Compiler


-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen


More information about the samba-technical mailing list