ldb patches made at samba XP
mat at samba.org
Mon May 24 23:04:44 MDT 2010
"Andrew Bartlett" <abartlet at samba.org> wrote:
>On Tue, 2010-05-25 at 01:59 +0400, Matthieu Patou wrote:
>> >> Hello Jelmer,
>> >> I resubmit you the patches that you coded on my laptop at XP.
>> >> Let me know when you'll apply them so that I can rebase my branch to
>> >> reduce the tail of patches.
>> > I notice this patch:
>> > create secrets used to leave the commit to calling function which is
>> > not good for the unittesting
>> > This was done deliberately - unit testing should call a wrapper the
>> > handles the commit if required. The idea is to avoid writing to the
>> > secrets.ldb if the rest of the provision failed.
>> > Andrew Bartlett
>> Thanks for pointing this.
>> I resubmit this patches with the following modification:
>> * no more modification of create_secrets, but I added a comments
>> * adapat unit tests.
>These look good to me! Do you want me to push them, or wait for jelmer
>to take a look?
>Also, if Jelmer wrote them, perhaps they should have him as Author?
I'm not an expert in git to manage to change the author (maybe a sed on patch file will do). But yes i 'd prefer that jelmer recheck what he did and take the paternity
>Andrew Bartlett http://samba.org/~abartlet/
>Authentication Developer, Samba Team http://samba.org
>Samba Developer, Cisco Inc.
Samba team. http://samba.org
More information about the samba-technical