[PATCH 3/4] s4: Add comments about setup_secrets

Matthieu Patou mat at matws.net
Sun May 23 23:41:44 MDT 2010

Comments are to inform people that this function should not handle
transaction within the function as it is mainly used in provision and
that we want to commit secrets only if all the action on secrets have
 source4/scripting/python/samba/provision.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py
index 5f7369a..388685e 100644
--- a/source4/scripting/python/samba/provision.py
+++ b/source4/scripting/python/samba/provision.py
@@ -721,6 +721,8 @@ def secretsdb_setup_dns(secretsdb, setup_path, private_dir,
 def setup_secretsdb(path, setup_path, session_info, backend_credentials, lp):
     """Setup the secrets database.
+       This function does not handle exceptions and transaction on purpose,
+       it's up to the caller to do this job.
     :param path: Path to the secrets database.
     :param setup_path: Get the path to a setup file.

Content-Type: text/x-patch;
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;

More information about the samba-technical mailing list