Fixing "-k" in S4 smbtorture.

Matthieu Patou mat at
Thu May 20 12:24:34 MDT 2010

Hi jeremy, it's a good idea but this command line parsing is also used in a lot of s4 utilities and if i read the patch well it will break scripts that use -k yes or -k 1 not 100 pleasant for admin among them me :-) 

"Jeremy Allison" <jra at> wrote:

>I just had to spend 10 minutes with a Microsoft
>engineer tracking down why the smbtorture command line
>options :
>smbtorture -k ncacn_ip_tcp:<name>[options] RPC-NETLOGON
>just said :
>Error parsing "-k ncacn_ip_tcp:<name>[options]".
>Of course, it needed :
>smbtorture -k yes ncacn_ip_tcp:<name>[options] RPC-NETLOGON
>instead :-(. I had to look in the source code for this
>to find out what "Error parsing XXX" meant for the -k
>option. Why does the -k option need to be followed
>by a bool ? Is there any case where someone would
>use "-k no" ?
>Given that, I'd like to push the following patch.
>Comments ?

Samba team.

More information about the samba-technical mailing list