[patch] cifs: return more accurate errno

Steve French smfrench at gmail.com
Tue May 18 23:32:24 MDT 2010

On Tue, May 18, 2010 at 12:18 PM, Steve French <smfrench at gmail.com> wrote:
> I will check.
> On Tue, May 18, 2010 at 7:06 AM, Jiri Kosina <jkosina at suse.cz> wrote:
>> On Fri, 7 May 2010, Dan Carpenter wrote:
>>> Smatch compains that we don't use the return value from get_dfs_path().
>>> In the original code if get_dfs_path() fails we return ERR_PTR(-ENOENT),
>>> but with this patch we can return errno from get_dfs_path() directly.
>>> Signed-off-by: Dan Carpenter <error27 at gmail.com>

ENOENT does seem like a safe return code if a DFS referral can not be
followed, but if the intent was to remap all error cases here to ENOENT
it would be easier to follow with something similar to your code e.g.

+       if (rc < 0) {
+               rc = -ENOENT;
+               goto out_err;
+      }

Did you intend to always return ENOENT for DFS when failures looking up
DFS referrals (probably most likely to be either error coming back from
 tree connect to IPC$ or error from the call to GetDFSRefer)?




More information about the samba-technical mailing list