'make test' or 'make selftest' in source3?

[Jelmer Vernooij]

On Mon, 2010-05-17 at 18:36 -0700, Jeremy Allison wrote:
> On Tue, May 18, 2010 at 02:37:51AM +0200, Jelmer Vernooij wrote:
> > On Fri, 2010-05-14 at 21:24 -0700, Jeremy Allison wrote:
> > > On Sat, May 15, 2010 at 11:52:41AM +1000, Andrew Bartlett wrote:
> > > > Given the work I'm doing on s3compat, I want to be careful not to break
> > > > anything in the source3/ and common code that I may modify.
> > > > 
> > > > So far, I've been doing that verification with 'make test', but there is
> > > > also 'make selftest'.  Which should I be using?  What is the different
> > > > between them, and how can we eventually get to having just one test
> > > > target?
> > > 
> > > I always use "make test", I think Guenther uses "make selftest".
> > "make test" is the old-style shell script, "make selftest" uses the same
> > (perl-based) infrastructure as Samba 4. The latter gives more granular
> > feedback and allows running individual tests. 
> > 
> > Now that the Samba 3 build depends on perl anyway (for pidl), would it
> > perhaps be possible to deprecate "make test" in favor of "make
> > selftest" ?
> Sure, I'll just have to learn where to add my tests again.
> There are some tests I added into "make test" I'd like
> to keep - I'll bug Guenther to get anything I need migrated
> over. Is it possible to run make selftest as root ? There
> are some (non mandatory) tests that need this.
Yep, it should be possible to run it as root. 

The list of tests it runs is generated by source3/selftest/tests.sh.

I'd also be happy to help getting the two test lists in sync.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100518/76f26db5/attachment.pgp>