[PATCH] More Samba3 changes for s3compat

Andrew Bartlett abartlet at samba.org
Tue May 18 01:28:55 MDT 2010

On Tue, 2010-05-18 at 08:58 +0200, Volker Lendecke wrote:
> On Tue, May 18, 2010 at 04:23:18PM +1000, Andrew Bartlett wrote:
> > I've also re-added to my request for review the patches to change Samba3
> > to use common structures for the auth subsystem.  I know they are hard
> > to review, and are currently opposed on these grounds, but this change
> > remains at the heart of the changes I'm proposing, and it needs to be
> > included.
> Any chance that we see a patchset without those changes,
> just with a s3compat auth module based on the current
> structures?

No, sorry.  We need to move these subsystems to shared structures in
both the long and short term.  Also, because of the way winbindd calls
into the auth code (it does not call the auth subsystem, but directly to
check_sam_security), there are now multiple entry points.  That is, a
auth_samba4 module alone would not solve the problem. 

The reason this approach has been so successful is that we already share
a great number of structures.  I propose to extend, not reduce that
number as I continue to advance the glue layer - particularly to avoid
having two similar but subtly different structures with the same name,
as is the case here. 

I have no objection to someone atomising that patch, if it helps, but I
would ask that this task be done in very close consultation with me, so
as to ensure I don't end up in rebase hell. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100518/80f7edf8/attachment.pgp>

More information about the samba-technical mailing list