[PATCH] More Samba3 changes for s3compat

Andrew Bartlett abartlet at samba.org
Tue May 18 00:23:18 MDT 2010

On Sat, 2010-05-15 at 00:25 +1000, Andrew Bartlett wrote:
> I would like some feedback on these patches.
> These include changes to PIDL (to avoid generating unwanted code that is
> harder to work around in s3compat) as well as another split of the
> winbindd.c code.
> I've also proposed to remove winbindd_kill_all_clients.  This seems
> unsued, but is perhaps a debugging tool?
> I apologise for the revert - I have now demonstrated multiple wbinfo -p
> operations with s3compat.  Previously, the source3/winbindd code would
> stop working after one ping, due to event conflicts between it's code
> and the stream_connection code. 
> http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s3compat-for-review
> I've got wbinfo -p and wbinfo -u now working on the s3compat winbindd,
> so I'm happier that I won't be changing approach dramatically.
> However, anything is possible, until I have everything built. 
> Please let me know if it's OK to merge any of these patches.

Can I please get some feedback on the patches I posted on Friday, or the
new set I've just uploaded to the git repo above?

The patch set has grown, and it's now not reasonable to attach to a mail
(moving line from file to file creates a large diff for a small change).

I've also re-added to my request for review the patches to change Samba3
to use common structures for the auth subsystem.  I know they are hard
to review, and are currently opposed on these grounds, but this change
remains at the heart of the changes I'm proposing, and it needs to be

The s3compat effort is moving along very well, and authentication now
succeeds with wbinfo -a against a Samba4 DC (in DC mode), and important
smb.conf options in Samba3 now follow on from Samba4, to avoid internal


Andrew Bartlett
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100518/a440d1e3/attachment.pgp>

More information about the samba-technical mailing list