[PATCH] More Samba3 changes for s3compat

Andrew Bartlett abartlet at samba.org
Fri May 14 17:24:55 MDT 2010


I would like some feedback on these patches.

These include changes to PIDL (to avoid generating unwanted code that is
harder to work around in s3compat) as well as another split of the
winbindd.c code.

I've also proposed to remove winbindd_kill_all_clients.  This seems
unsued, but is perhaps a debugging tool?

I apologise for the revert - I have now demonstrated multiple wbinfo -p
operations with s3compat.  Previously, the source3/winbindd code would
stop working after one ping, due to event conflicts between it's code
and the stream_connection code. 

http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s3compat-for-review

I've got wbinfo -p and wbinfo -u now working on the s3compat winbindd,
so I'm happier that I won't be changing approach dramatically.
However, anything is possible, until I have everything built. 

Please let me know if it's OK to merge any of these patches.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-s3-winbind-Split-winbindd.c-into-3-files.patch.gz
Type: application/x-gzip
Size: 9095 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Revert-s3-winbindd-Split-helper-functions-to-allow-s.patch.gz
Type: application/x-gzip
Size: 1399 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pidl-Allow-new-property-no_srv_register.patch.gz
Type: application/x-gzip
Size: 1000 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-s3-winbindd-Move-more-parts-of-winbindd.c-into-winbi.patch.gz
Type: application/x-gzip
Size: 4623 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-s3-winbind-Kill-amusing-but-un-used-winbindd_kill_al.patch.gz
Type: application/x-gzip
Size: 758 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-winbind-use-no_srv_register-to-avoid-needing-rpc_.patch.gz
Type: application/x-gzip
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-s3-winbindd-move-reinit_after_fork-back-out-of-winbi.patch.gz
Type: application/x-gzip
Size: 903 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s3-smbd-Move-a-few-functions-out-of-smbd-server.c.patch.gz
Type: application/x-gzip
Size: 4885 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/a89462cd/attachment.pgp>


More information about the samba-technical mailing list