upgradeprovision error

Andrew Bartlett abartlet at samba.org
Fri May 14 17:19:24 MDT 2010

On Fri, 2010-05-14 at 13:10 +0300, Anatoliy Atanasov wrote:
> > > On Thu, 2010-05-13 at 15:11 +0300, Anatoliy Atanasov wrote:
> > > Hi Andrew,
> > > 
> > > Here are the patches. Please take a look and push if its ok.
> > 
> > It looks OK, except that you should really use a real boolean - true 
> > and
> > false in the python.  
> > 
> > Also, I don't like it just being a default value in setup_samdb() - it
> > should either be hardcoded lower down, or set up at the provision()
> > layer like all the other defaults. 
> I thought that someday when we make the provision to call vampire this will be re-factored.
> Anyway, you are right that this way is better.
> I attached them again.

Almost there!  I would suggest you don't need to modify setup/provision
at all, and just use the code you have already done to have the default
value in provision().

Otherwise, it looks good (assuming it works :-)

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100515/9952804e/attachment.pgp>

More information about the samba-technical mailing list