[PATCH] Changes to Samba3 to allow login with NTLM and Kerberos in s3compat

[Jeremy Allison]

On Mon, May 10, 2010 at 06:11:14PM +0200, Stefan (metze) Metzmacher wrote:
> Andrew Bartlett schrieb:
> > On Sun, 2010-05-09 at 21:28 +1000, Andrew Bartlett wrote:
> >> On Sat, 2010-05-08 at 21:56 +1000, Andrew Bartlett wrote:
> >>> On Fri, 2010-05-07 at 22:50 +1000, Andrew Bartlett wrote:
> >>>> These attached patches I wish to propose to Samba3 to make it easier to
> >>>> build s3compat, and to maintain it into the future.
> >>>>
> >>>> Regardless of if we choose to go with s3compat, I think these are useful
> >>>> cleanups. 
> >>>>
> >>>> With these patches in, other code in the s3compat branch allows logins
> >>>> using either NTLM or Kerberos to the Samba3 file server hosted in
> >>>> Samba4.  I actually think this is pretty amazing, and has only been so
> >>>> practical because of the long, tedious work done to ensure that the IDL
> >>>> and many other building block structures are identical throughout
> >>>> Samba. 
> >>>>
> >>>> (The patches are posted here for review.  I hope to test them both -
> >>>> particularly the kerberos one - more, but I'm fighting Samba4 bugs to
> >>>> get the test environment going). 
> >>> I've verified the net ads kerberos pac command, and Samba3 as a domain
> >>> member getting Kerberos tickets, as well as NTLM and Kerboros logins. 
> >>>
> >>> All the auth changes I'm hoping to have merged are being kept in my
> >>> s3auth-rework branch.  
> >>>
> >>> Could someone please review these changes so I can merge them?
> >> BTW, if someone else is interested in the s3comapt work, I would really
> >> like to pair-program or do review/merge cycles with another developer.  
> >>
> >> Otherwise, it would be good to at least establish a protocol by which I
> >> can get some of these interface changes merged in a predictable
> >> timeframe.  
> > 
> > The above makes it seem like my patches have been totally ignored, and I
> > apologise for that implication.  
> > 
> > metze is helping me with
> > 0002-s3-auth-Make-Samba3-use-the-new-common-struct-auth_u.patch.  
> 
> I started to look at the others too and will continue tomorrow (and very
> likely push them then)

Thanks Metze, I was planning to do this but finishing SMB2
tests comes first :-).

Jeremy.