Patches for dealing a bit more cleanly with NTTIME

Jelmer Vernooij jelmer at
Sun May 2 07:51:29 MDT 2010

Hi Matthieu,

On Sun, May 02, 2010 at 03:31:11PM +0400, Matthieu Patou wrote:
> Any news on this patch ? it seems that it's not in master.
Sorry for the delay; it's merged now.



> On 20/04/2010 11:25, Matthias Dieter Walln?fer wrote:
> >Hi Jelmer,

> >this is the thread where ekacnet posted his NTTIME patch (I think
> >you haven't noticed it).

> >Matthias

> >Matthieu Patou wrote:
> >>Hi jelmer,

> >>Find attach the new version without any cast + assignement in SamDB.

> >>On 15/04/2010 00:47, Jelmer Vernooij wrote:
> >>>Hi Matthieu,

> >>>On Thu, 2010-04-15 at 00:37 +0400, Matthieu Patou wrote:
> >>>>Hello jelmer,

> >>>>This patch is for dealing correctly with NTTIME (64bits) + allowing to
> >>>>print a NTTIME object in a string.
> >>>You're using PyInt_FromLong((uint64_t)t). That seems wrong because
> >>>sizeof(uint64_t)>  sizeof(long) and t is a time_t. Perhaps you just
> >>>don't want to cast at all?

> >>>Cheers,

> >>>Jelmer


More information about the samba-technical mailing list