[PATCH] smbcacls added support for a -I flag

[Volker Lendecke]

On Wed, Apr 28, 2010 at 01:20:15AM -0700, matthew at mcgillis.org wrote:
> This message should include an attachment of the patch.
> This used MacOS X Mail.
> 
> Let me know if your still running into problems.

Ok, this works fine, thanks!

Some comments on the patch: It still compiles with warnings
about unused variables and declarations after statements.
Those are easy to fix. I always compile with

-g -Wall -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -DDEBUG_PASSWORD -DDEVELOPER -Wdeclaration-after-statement -Werror-implicit-function-declaration -Wc++-compat -pipe -g -O3 -D_FORTIFY_SOURCE=2 -Wshadow -Wpointer-arith -Wcast-align -Wfloat-equal -Wstrict-aliasing=2 -Wpointer-arith -Wwrite-strings -Wmissing-prototypes -Wmissing-declarations -Wnested-externs

which catches many of these problems for me.

One real requestion though: Your patch contains changes to
for example cacl_dump, to owner_set etc. Some of those seem
to be pure reformattings, but to me that seems a bit
difficult to really review for the real changes. For example
there's a hunk in your patch that says

 static int owner_set(struct cli_state *cli, enum chown_mode change_mode, 
-                       const char *filename, const char *new_username)
+                    char *filename, const char *new_username)
 {

You've removed the const here. To me it seems that this was
required because the routine get_fileinfo() does not have
that const. Can you change the patch to add the const to
get_fileinfo instead of removing it from owner_set? I would
like to see a patch that contains almost only + and almost
no - if possible.

Thanks,

Volker


> 
> Regards,
> Matthew
> 



-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100502/c744f9db/attachment.pgp>