pidl:Samba4/Client: don't mix rpc and application NTSTATUS errors anymore for the new bindings

[Andrew Bartlett]

On Mon, 2010-03-29 at 09:43 -0500, Stefan Metzmacher wrote:
> The branch, master has been updated
>        via  e230c8d... pidl:Samba4/Client: don't mix rpc and application NTSTATUS errors anymore for the new bindings
>        via  979c50e... s4:torture/rpc/samba3rpc.c: add explicit check for NTSTATUS r.out.result
>        via  733701a... s4:libnet/libnet_passwd.c: add explicit check for NTSTATUS r.out.result
>        via  cd3ae92... s4:libnet/libnet_samsync.c: add explicit check for NTSTATUS r.out.result
>        via  d0efef3... s4:libnet/libnet_join.c: add explicit check for NTSTATUS r.out.result
>        via  12ee027... s4:libcli/util/clilsa.c: add explicit check for NTSTATUS r.out.result
>        via  10e46e5... s4:torture/rpc/lsa.c: add explicit check for NTSTATUS r.out.result
>        via  1a4d9b9... s4:torture/rpc/samr.c: add explicit check for NTSTATUS r.out.result
>        via  e531b52... s4:torture/rpc/handles.c: add explicit check for NTSTATUS r.out.result
>        via  3398636... s4:torture/rpc/samr_accessmask.c: add explicit check for NTSTATUS r.out.result
>        via  08177e9... s4:torture/rpc/samsync.c: add explicit check for NTSTATUS r.out.result
>        via  5dcb1e5... s4:torture/rpc/samlogon.c: add explicit check for NTSTATUS r.out.result
>        via  2f7f725... s4:torture/rpc/netlogon.c: add explicit check for NTSTATUS r.out.result
>        via  8ac42bc... s4:torture/rpc/lsa_lookup.c:add explicit check for NTSTATUS r.out.result
>        via  1248adb... s4:torture/libnet:add explicit check for NTSTATUS r.out.result
>        via  2d35523... s4:torture/rpc/schannel.c: add explicit check for NTSTATUS r.out.result
>        via  940c6ab... s4:torture/rpc/remote_pac.c: add explicit check for NTSTATUS r.out.result
>        via  a154bb5... s4:torture/rpc/testjoin.c: add explicit check for NTSTATUS r.out.result
>        via  959a128... s4:torture/rpc/session_key.c: add explicit check for NTSTATUS r.out.result
>        via  583c7cb... s4:torture/rpc/eventlog.c: add explicit check for NTSTATUS r.out.result
>        via  159ca62... s4:torture/rpc/unixinfo.c: add explicit check for NTSTATUS r.out.result
>        via  1184ef6... s4:torture/ntp: add explicit check for NTSTATUS r.out.result
>        via  0590e7e... s4:torture/rpc/atsvc.c: add explicit check for NTSTATUS r.out.result
>        via  fd94954... s4:torture/rpc/echo.c: remove NTSTATUS status variables
>        via  870a21b... s4:torture/rpc/echo.c: add explicit check for NTSTATUS r.out.result
>       from  8b1651c... s3: Fix bug 7212, "getent group does not return group members"
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit e230c8dd2441181963c6df678be06cdaaf6cb822
> Author: Stefan Metzmacher <metze at samba.org>
> Date:   Sat Mar 27 12:48:21 2010 +0100
> 
>     pidl:Samba4/Client: don't mix rpc and application NTSTATUS errors anymore for the new bindings
>     
>     The new dcerpc_binding_handle based client stubs don't mix error codes anymore,
>     while the old dcerpc_pipe based ones still do to keep OpenChange happy for now.
>     
>     metze

Metze,

This seems a step back into the past. 

When Samba4 started, this was how we programmed DCERPC.  It was a
disaster - the extra check was forgotten so often that we moved to the
current scheme, where application and NDR level errors were combined, so
that both were kept checked.

How are we going to avoid this happening again, now that we have
returned to that API?

It seems very rare that we actually wish to do anything *except* combine
the error codes.  Why not have an API that does that by default, and
allow the separate error codes to be inspected in the rare cases where
that is desired?

I really appreciate your work here, but perhaps you could put big
changes like this past the list for comment?  (I know it's on your wiki
page at http://wiki.samba.org/index.php/DCERPC but I just didn't realise
this was what you meant!)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100330/423b833f/attachment.pgp>