[PATCH] s4-drs: DsGetReplInfo(), infoType = DS_REPL_INFO_METADATA_2_FOR_OBJ

[Erick Nascimento]

Hi Tridge!
Should the test for the DsGetReplInfo() call be on
source4/torture/rpc/drsuapi.c instead of
source4/torture/rpc/dsgetinfo.c?
In drsuapi.c there is the function test_DsReplicaGetInfo() which also
has an implementation of the test case for DsReplicaGetInfo(),
duplicating the testcase on dsgetinfo.c. How should this be solved ?

Thanks,
Erick Nogueira do Nascimento
Institute of Computing
Campinas State University

2010/3/24 Erick Nascimento <erick.nogueira.nascimento at gmail.com>:
> Andrew,
>
> Here is one patch that add a line on selftest/knowfail for the
> dsgetinfo test cases.
> The another one just fix the return value for not yet supported infoTypes.
>
> Thanks,
> Erick Nogueira do Nascimento
> Institute of Computing
> Campinas State University
>
> On Fri, Mar 19, 2010 at 9:05 PM, Andrew Bartlett <abartlet at samba.org> wrote:
>> On Fri, 2010-03-19 at 20:36 -0300, Erick Nascimento wrote:
>>> Andrew,
>>>
>>> Here is a patch fixing this. The comments are inside.
>>> I don't know much about the torture testcases purposes, I tough it was
>>> ok to remove the not yet supported infotypes from being called, but
>>> maybe I'm wrong.
>>
>> No, you should instead write up the tests in such a way that they are
>> either not called against Samba4, or (much better) to add them to the
>> known failure file.
>>
>> Tests should be written to pass against Windows 2008 R2, and then
>> knownfail updates made so that when run against Samba4, they don't break
>> the overall test.
>>
>> Andrew Bartlett
>>
>> --
>> Andrew Bartlett                                http://samba.org/~abartlet/
>> Authentication Developer, Samba Team           http://samba.org
>> Samba Developer, Cisco Inc.
>>
>>
>