[PATCH] Prevent the overwriting of global errno in set file info code path.

[Volker Lendecke]

On Tue, Mar 16, 2010 at 10:10:07AM +0200, Surbhi Palande wrote:
> BugLink: http://launchpad.net/bugs/276472
> 
> In the code path for setting the file info, the set_unix_posix_default_acl()
> calls set_unix_posix_default_acl() for setting the posix acl. The mapping of
> the unix errors to NT errors is based on the global error numbers set by the
> set_unix_posix_default_acl(). However this error number is overwritten by
> a call to SMB_VFS_SYS_ACL_FREE_ACL() before returning from
> set_unix_posix_default_acl(). The overwritten value is a -EINVAL. This
> translates to the NT_STATUS_ACCESS_DENIED instead of the expected
> NT_STATUS_NOT_SUPPORTED error code.

While the patch looks correct and does not hurt, I would
like to know a bit more why it is necessary. Why does
acl_free set errno at all? Looking at the manpage I get the
impression that it should only set errno if it returns -1.
Why in this routine would it set EINVAL? It seems to point
at a different bug if acl_free does not like the acl we give
it.

Before pushing it, can you explain what's going on in your
case?

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100316/b4043cd5/attachment.pgp>