[PATCH] s4: initial code for the topology algorithm

[Crístian Viana]

Hi Matthias,

I hadn't noticed that num_values is an unsigned int. The corresponding
counters are now fixed and they should match the num_values type.

Thanks for your comment!

Cheers,
Crístian.

On Mon, Mar 8, 2010 at 8:25 AM, Matthias Dieter Wallnöfer <mdw at samba.org>wrote:

> I looked at the patch.
>
> One small comments: it's very nice that you use "uint32_t" counters and not
> the "signed" pedants where there isn't need to.
> But rember: when counting objects from the LDB api (not DSDB, RPC api...)
> (with the "num_*" variables) use "unsigned" counters (not "uint32_t", not
> "uint64_t") since this is what the specification prescribes. The "num_*" are
> of this type and so also the counters should be. Keep in mind:
> sizeof("unsigned") >= sizeof("uint32_t"), on most platforms equal but
> "unsigned" could be greater.
>
> Greets,
> Matthias
>
>
> Crístian Viana wrote:
>
>> Hi,
>>
>> I think you should leave the inter-site algorithm alone now, and start
>>
>>
>>> working on the intra-site algorithm.
>>>
>>>
>>>
>> When you sent this e-mail I was nearly at the end of that algorithm, so I
>> decided to finish it. I took a couple of days reviewing the code and
>> testing
>> it, and only today I could send the patches. It isn't fully functional as
>> there are some parts I don't know how to implement. Those parts have TODO
>> comments explaining what should be done that I didn't understand.
>>
>> Cheers,
>> Crístian.
>>
>>
>>
>
>


-- 
Crístian Deives dos Santos Viana [aka CD1]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-unsigned-instead-of-uint32_t-for-LDB-counters.patch
Type: application/octet-stream
Size: 1845 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100309/57136490/attachment.obj>