[PATCH] s4-drs: DsGetReplInfo(), infoType = DS_REPL_INFO_METADATA_2_FOR_OBJ

Matthias Dieter Wallnöfer mdw at samba.org
Mon Mar 8 15:14:28 MST 2010


Hi Erick,

also here my quick comment:

 >> int ret, i;
...
 >> for (i=0; i<md.ctr.ctr1.count; i++) {

Please don't use type "int" for "i" when you see that the upper limit 
"md.ctr.ctr1.count" is of type "uint32_t" (DSDB specification). Use 
"uint32_t" instead. Using "int" for "ret" is fine (LDB specification). 
Similar when counting LDB objects (through "num_*" variables) do use 
"unsigned int" and not "int".

I hope that Tridge comments regarding the content.

Greets,
Matthias

Erick Nascimento wrote:
> (Sorry for the last msg, I forgot the [PATCH] on the subject.)
>
> Hi Tridge!
>
> This is a patch for the implementation of the infoType
> DS_REPL_INFO_METADATA_2_FOR_OBJ of DsGetReplInfo().
>
> Best Regards,
>
> Erick Nogueira do Nascimento
> Institute of Computing
> Campinas State University
>    



More information about the samba-technical mailing list