Patch for review

Stefan (metze) Metzmacher metze at samba.org
Mon Mar 8 03:53:21 MST 2010


Volker Lendecke schrieb:
> Hi!
> 
> Attached find a patch with a lengthy commit message. This is
> pretty subtle stuff and possibly incomplete.
> 
> Please punch holes into it before it goes in....

Looks very good to me!

Just some minor things:

- Is it intended to sometimes use ...(const struct server_id id)
  and sometimes ...(const struct server_id *id)?
  I'd prefer to use one way consistently.

- Do we still need count_current_connections() and yield_connection()
  connection in winbindd?

- Don't we need to somehow call serverid_deregister() within nmbd and
  winbindd?

- I think you could split the changes to "net" to its own commit

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100308/3132e6f8/attachment.pgp>


More information about the samba-technical mailing list