patch S4: Winbind, implement getgroups

[Kai Blin]

On Thursday 04 March 2010 14:56:46 Matthieu Patou wrote:

Hi Matthieu,

> I repushed everything in my branch I added tag end_reviewable to mark
> the limit of changeset that should be reviewed (because after it's more
> work in progress).
> I changed this:
> 
> * remove big chunck of commented code
> * reorganize getgroups to have send and after receive (also in
> wb_samba4_cmd.c)
> * make it cleaner for Andrew B. needs

The patches look much better now, but I still have two little nitpicks:

In patch 43ea249a432c5fdd3aab72f1434e90668150e4ae (stub implementation of 
WINBINDD_PAM_LOGOFF), please move the case statement above the "unimplemented" 
comment. For the purpose of that switch statement, it is implemented even if 
it's only a stub.

Also, can you please merge 3c524a90c6fc95ecbb13b3953ef80cd2e7c740aa (comments 
and reformatting) to the appropriate changes? There's no reason to keep this 
as a separate commit.

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100307/f5835553/attachment.pgp>