[Patches] proposal in order to allow to be able to have pam_winbind libs in s4

Matthieu Patou mat at matws.net
Thu Mar 4 09:50:32 MST 2010


Readd INIPARSERCFLAGS="-I$srcdir/$iniparserdir/src" because it's needed.


On 04/03/2010 19:10, Matthieu Patou wrote:
> In the hope that it will be the last version !
>
> There is also a branch here 
> http://repo.or.cz/w/Samba/ekacnet.git/shortlog/refs/heads/libpam_winbind
>
> Matthieu.
>
> On 01/03/2010 00:35, Matthieu Patou wrote:
>> Hello Metze,
>>
>> I updated the patch to take your comments in account.
>>
>> Let me know !
>> On 24/02/2010 00:24, Matthieu Patou wrote:
>>> On 20/02/2010 11:35, Stefan (metze) Metzmacher wrote:
>>>> Matthieu Patou schrieb:
>>>>> Hello,
>>>>>
>>>>> Please find attached a couple of patch that allow to have the
>>>>> pam_winbind.so it compiles on s3 and s4 but I didn't run make 
>>>>> tests on
>>>>> them (yet).
>>>>
>>>> Please move iniparser to lib/iniparser to match other imported libs
>>>> like zlib and popt.
>>>>
>>>> I think the usage of dyn_LOCALEDIR in pam_winbind.c is wrong,
>>>> it will never be able to change the value to something other than
>>>> LOCALDIR. I think we should use LOCALDIR directly.
>>>>
>>> Is everybody Ok with this modification  ? it should impact s3 as 
>>> well if I'm not misunderstanding ?
>>>> Then we don't have to move the localdir.[ch] files.
>>>> (If you want them to move anyway they should both move to lib/util/)
>>>>
>>>> metze
>>>>
>>>>
>>>
>>> Matthieu.
>>
>



More information about the samba-technical mailing list