group mapping in Samba3

[simo]

On Wed, 2010-03-03 at 08:45 +1100, tridge at samba.org wrote:
> Hi Simo,
> 
>  > This is my experience too, I've never found many mappings being used in
>  > member servers. So it has always been more a theoretical issue than a
>  > real deployment issue. Of course I bet someone out there will have the
>  > one exception that makes this painful :)
> 
> You may wish to look at the test suite I used to develop and maintain
> the group mapping code in s3. See script/tests/test_groupmap.sh. 
> 
> Just adjust the NLOCAL, NGROUP and NBUILTIN numbers to test scaling
> very easily.
> 
> Note that this doesn't run in the buildfarm as it needs root to create
> real local users and groups to map to, so you need to test it manually
> for s3 releases (I'm guessing that by removing my code and reverting
> to the old code that you are the new maintainer for this subsystem?)
> 
> I also think you may wish to test the stated goal of your change,
> which I'm guessing is to make it possible to upgrade to clustered
> Samba without losing group mappings. I don't think you've actually
> achieved that, as I think you may not have realised that the tdb
> format for clustered and non-clustered tdb is different (different
> record headers). So you'll need a conversion tool.

No the goal is to use just one code path and avoid duplicates, automatic
conversion from non-cluster to cluster was evidently not part of this
patch.

> Could you also please check that your auto-upgrade works with a
> group_mapping.ldb created with the first release of s3 that had ldb
> based group mapping? I notice you've removed support for the NODN
> varient of the ldb record format when you copied the code over from
> ldb_pack.c. It would be worthwhile checking that this is not cause any
> problems.

I've checked that before pushing the patch. I don't handle the NODN case
simply because when we pushed ldb in S3 we were already using the new
format, so there can't be databases in the wild that use that old
format.

See 3e2c696e45b24b0192ab7b1ddaf1dd4d79571609

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>