[SCM] Samba Shared Repository - branch master updated

simo idra at samba.org
Mon Mar 1 13:22:32 MST 2010


Matthias,
this kind of problems is the reason why I am a bit uncomfortable with
your patch to change in one sweeping move all internal ""counters"" in
ldb to unsigned.

Simo.

On Mon, 2010-03-01 at 14:19 -0600, Matthias Dieter Wallnöfer wrote:
> The branch, master has been updated
>        via  05bd8c1... s4:srvsvc RPC - revert one unsigned integer "i" back to signed
>       from  cf12d45... testprogs: better usage text.
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 05bd8c17be83057b9bcfe405fb29d27a794b9b40
> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> Date:   Mon Mar 1 21:11:39 2010 +0100
> 
>     s4:srvsvc RPC - revert one unsigned integer "i" back to signed
>     
>     This is needed since this particular "i" counts until "count" which itself is
>     signed. "count" is set through a signed integer variable parameter from the
>     "share_list_all" call.
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source4/rpc_server/srvsvc/dcesrv_srvsvc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
> index 90edadb..d1e3f53 100644
> --- a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
> +++ b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
> @@ -1384,7 +1384,7 @@ static WERROR dcesrv_srvsvc_NetShareCheck(struct dcesrv_call_state *dce_call, TA
>  	char *device;
>  	const char **names;
>  	int count;
> -	unsigned int i;
> +	int i;
>  
>  	*r->out.type = 0;
>  
> 
> 


-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list