[PATCH] s4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag

Kamen Mazdrashki kamenim at gmail.com
Mon Jun 28 17:07:21 MDT 2010


Hi Tridge,

As you introduced the idea of having helper dsdb_module_ functions that
takes
a set of flags to control their behavior (ldap controls, module chain
execution..),
what do you thing about introducing a DSDB_FLAG_NEXT_MODULE flag?

You can review the patchset at:
http://gitweb.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/dsdb_flag_next_module

<http://gitweb.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/dsdb_flag_next_module>Basically
the idea is for callers to explicitly specify how exactly they want function
to be executed.
Currently if DSDB_FLAG_OWN_MODULE or DSDB_TOP_OWN_MODULE are not specified,
then call is executed on the next module in the chain implicitly.
The same effect is achieved when passing magic '0' as a flag.
IMO, specifying explicitly DSDB_FLAG_ to control function behavior is much
more
obvious when reading the code (one don't need to look at the implementation
to instantly
understand how the call will be executed)

-- 
CU,
Kamen Mazdrashki
Samba Team Developer         http://samba.org
http://gitweb.samba.org/?p=kamenim/samba.git;a=summary
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/
kamen.mazdrashki at postpath.com


More information about the samba-technical mailing list