[RFC] [PATCH] talloc: Look up parents in O(1) time instead of O(n).

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Jun 26 02:32:05 MDT 2010

On Fri, Jun 25, 2010 at 10:17:32PM -0700, Kenneth Graunke wrote:
> Previously, only parent->child (the head of the list of children)
> pointed to its parent; the others had a parent pointer of NULL.  This
> meant that one had to traverse the list in reverse to find a parent.
> The tradeoff is that talloc_realloc now must update all children's
> parent pointers.

That looks very reasonable to me. "make test" in s3 survives
the same way as without the patch, "make test" in s4 is
still running but I don't see any failures so far that would
be attributed to this patch.

To get this in, Tridge must ack it.


More information about the samba-technical mailing list