[PATCH] make schannel.tdb TDB_CLEAR_IF_FIRST

[Volker Lendecke]

On Thu, Jun 24, 2010 at 09:22:53AM +1000, Andrew Bartlett wrote:
> Attached again is my proposed set of changes.  They pass 'make test' in
> Samba3 and Samba4, and I've manually verified that the
> TDB_CLEAR_IF_FIRST behaviour is applied correctly (by inspection with
> tdbdump while conduction schannel operations against Samba3)
> 
> I think I've followed the pattern given above correctly.  If someone
> could please push/review/comment I would very much appreciate it. 

The changes technically look ok. In particular, as we should
remove all non CLEAR_IF_FIRST uses of tdb without
transactions. I just wonder where the fsyncs in your tests
come from. I have always thought that tdb does not do fsyncs
when no transactions are used, but I might be wrong.

Can you explain where the fsync calls in your test come
from?

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100624/dfc4a97f/attachment.pgp>