unit test not passing on my computer
Matthias Dieter Wallnöfer
mdw at samba.org
Tue Jun 22 00:26:50 MDT 2010
Hi Lukasz,
if grouptype is not None:
- ldbmessage["groupType"] = "%d" % ((grouptype)-2**32)
+ ldbmessage["groupType"] = "%d" % ((grouptype + 2**31) % 2**32 - 2**31
^^^ isn't this "groupType" alignment easier to do? Shouldn't "groupType
% 2**32" alone fit ?
Matthias
Lukasz Zalewski wrote:
> Matthieu,
> Attached is the patch that fixes the problems when assigning
> (converting) grouptype value on 64 and 32 bit architectures. I have
> tested this on both architectures and both produce exactly the same
> values. Please let me know if this works for you
>
> Luk
More information about the samba-technical
mailing list