[PATCH][SAMBA4] resurrect and enhance smbtorture shell

James Peach jamespeach at me.com
Mon Jun 21 12:27:10 MDT 2010

On Jun 20, 2010, at 7:28 AM, Jelmer Vernooij wrote:

> Hi James,
> On Wed, 2010-05-26 at 20:36 -0700, James Peach wrote:
>> Attached is a series of patches that resurrect the smbtorture --shell
>> functionality and enhance it so that no additional commandline options
>> are needed.
>> The shell functionality is quite useful to me. I run an internal server
>> with smbtorture as a login shell. This allows various QA groups to
>> remotely run smbtorture against whatever they happen to be testing,
>> and I don't need to worry about making sure they have a suitably
>> recent version  of smbtorture.
> This looks good to me, apart from the use of C++ style comments in a few
> places.

I'll remove these and fix a command line parsing bug I just noticed.

> As far as I know you can still push these;

I'll give it a shot

> if you'd like me to do so please let me know.

Cool, thanks for the review ...

> Cheers,
> Jelmer

More information about the samba-technical mailing list