Patch to fix a segfault while duping some security descriptors

Matthias Dieter Wallnöfer mdw at samba.org
Sat Jun 19 13:38:22 MDT 2010


Well, I don't see it in.

Nadezhda Ivanova wrote:
> Hi,
> As I remember I reviewed the patch and Anatoliy pushed it. It should 
> be in already.
>
> On Fri, Jun 18, 2010 at 7:44 PM, Matthias Dieter Wallnöfer 
> <mdw at samba.org <mailto:mdw at samba.org>> wrote:
>
>     Nadia,
>
>     do we still need this patch? Would you like to push it? Or how to
>     proceed here?
>
>     Matthias
>
>
>     Nadezhda Ivanova wrote:
>
>         Hi,
>         That's a nice fix, but where is the caller that provided an
>         uninitialized
>         DACL? Maybe that needs fixing too.
>
>
>         On Wed, May 26, 2010 at 12:49 AM, Anatoliy Atanasov<
>         anatoliy.atanasov at postpath.com
>         <mailto:anatoliy.atanasov at postpath.com>>  wrote:
>
>
>             Hi there,
>
>             I had the same problem :), just waiting for the patch to
>             be approved before
>             pushing it.
>
>             Thanks,
>             Anatoliy
>             ----- Original Message -----
>
>                 From: samba-technical-bounces at lists.samba.org
>                 <mailto:samba-technical-bounces at lists.samba.org><
>
>             samba-technical-bounces at lists.samba.org
>             <mailto:samba-technical-bounces at lists.samba.org>>
>
>                 To: samba-technical at lists.samba.org
>                 <mailto:samba-technical at lists.samba.org><samba-technical at lists.samba.org
>                 <mailto:samba-technical at lists.samba.org>>
>                 Sent: Wednesday, May 26, 2010 0:04:47 AM (GMT+02:00)
>                 Athens, Bucharest,
>
>             Istanbul
>
>                 Subject: Patch to fix a segfault while duping some
>                 security descriptors
>
>
>                     I found a segfault when duplicating a security
>                     descriptor that was
>
>                 missing sacls or dacls. I ran into this when a piece
>                 of my code wrote
>                 a security descriptor for an LDAP user that had no
>                 sacls. After doing
>                 that, checking or unchecking the "User cannot change
>                 password" option
>                 in the AD admin tool would cause samba to crash.
>
>                 I fixed this by checking if the acl was null in
>                 security_acl_dup
>                 function, and returning NULL if that was the case.
>
>
>
>
>



More information about the samba-technical mailing list