[PATCH] s4/waf: Add '--no-manpages' option

[Kamen Mazdrashki]

On Fri, Jun 18, 2010 at 14:47, Jelmer Vernooij <jelmer at samba.org> wrote:

> On Fri, 2010-06-18 at 14:23 +0300, Kamen Mazdrashki wrote:
> > On Fri, Jun 18, 2010 at 11:04, Stefan (metze) Metzmacher
> > <metze at samba.org> wrote:
>
> >         Yes, I also don't like the 2nd patch. Developers should notice
> >         if the
> >         generation
> >         of manpages is broken.
> > I don't have the impression most of the developers care about man
> > pages generation,
> > perhaps it is a wrong impression though :)
> Even if they don't view the manpages it's important for them to notice
> when they break.
>

I just can't image how can one break man pages while writing C/Python code?
:)
On the other hand, I am changing something in man pages, then I would be
using plain configure as this is the way the release will be build right?



>
> >         If modified the first patch a bit, see
> >
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-tmp
> >         And also skip the generation of pidl manpages with
> >         --no-manpages.
>
> > What do you thing about this one:
> >
> http://gitweb.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/no-manpages
>
>
> >         > Rather, if you'd want to not have to specify this flag we
> >         should detect
> >         > if the user has the stylesheets installed locally and only
> >         prohibit
> >         > generating them if they don't have them.
> >
> >
> >         Yes, the usage of --nonet would be really good as a default,
> >         together with a test that checks if we can generate a trivial
> >         manpage
> >         when using the --nonet option.
> >
> > Such an option would be my favorite :)
> > (I recall that stand alone build for talloc also wants style sheets
> > from the net, right?)
> talloc (like Samba) only uses stylesheets from the net if you don't have
> them installed locally.
>
> Is there a particular reason you can't install docbook-xsl ? With that
> package installed it takes less than 10 seconds to generate the manpages
> here.
>

Yes. I've been very annoyed when it took me 30 mins to make a build few days
ago.
By this time, I used to spent 5-7min on this, so I was quite surprised when
my build went so long for no particular reason.
Then I had some hard time to find out that I need docbook-xsl
(thanks to abartlet for pointing me at the right thread in samba-technical).
I guess there are a lot of people like me, that are working on small parts
of Samba,
and all the sudden, they have to wait for so long to have a clean build,
right?

Another use case for this -> I am developing/testing on machines that are
not
online all the time. So when I had to rebuild samba, I hadn't been able to
do so.
In this particular case, I don't  even have a work-around :)

For the latter case I like pretty much Metze's idea for '--nonet' switch to
cut off
any attempts to access network during samba build.

I hope I made my point clear - it is just more usability for developers :)

-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://gitweb.samba.org/?p=kamenim/samba.git;a=summary
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/