[PATCH] Fix warning messages about unused result of talloc_move. We're really talloc_steal'ing here.

Jeremy Allison jra at samba.org
Mon Jun 14 16:55:19 MDT 2010


---
 libcli/named_pipe_auth/npa_tstream.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libcli/named_pipe_auth/npa_tstream.c b/libcli/named_pipe_auth/npa_tstream.c
index c96e30f..273c412 100644
--- a/libcli/named_pipe_auth/npa_tstream.c
+++ b/libcli/named_pipe_auth/npa_tstream.c
@@ -1324,7 +1324,7 @@ static void tstream_npa_accept_existing_reply(struct tevent_req *subreq)
 			DEBUG(0, ("Out of memory!\n"));
 			goto reply;
 		}
-		talloc_move(state->info3, &pipe_request);
+		talloc_steal(state->info3, pipe_request);
 
 		/* we need to force byte mode in this level */
 		state->file_type = FILE_TYPE_BYTE_MODE_PIPE;
@@ -1531,9 +1531,9 @@ int _tstream_npa_accept_existing_recv(struct tevent_req *req,
 	*server_name = talloc_move(mem_ctx, &state->server_name);
 	*info3 = talloc_move(mem_ctx, &state->info3);
 	*session_key = state->session_key;
-	talloc_move(mem_ctx, &state->session_key.data);
+	talloc_steal(mem_ctx, state->session_key.data);
 	*delegated_creds = state->delegated_creds;
-	talloc_move(mem_ctx, &state->delegated_creds.data);
+	talloc_steal(mem_ctx, state->delegated_creds.data);
 
 	tevent_req_received(req);
 	return 0;
-- 
1.7.0.1


--bp/iNruPH9dso1Pn--


More information about the samba-technical mailing list