abartlet at samba.org
Sat Jun 12 02:40:33 MDT 2010
On Thu, 2010-06-10 at 02:03 +0400, Matthieu Patou wrote:
> Hello Andrew & Jelmer,
> I finally finished chuncking the whole thing.
> I push bits of reformatting up and down when possible to ship them with
> patches that were modifying the same stuff (so that the patch appear to
> modify the logic _and_ in the same time put it in quite correct format).
> I normaly addressed all "%", ",", "\" (well most of them let say) in the
> different patches + last remarks of jelmer yesterday.
> I think now that some intermediate patches can be remerged.
> For the moment I didn't rerun make tests, and it's possible that some
> regression have been done because the code has been heavily manipulated.
> I'll try to do it soon. In the meanwhile please do remarks.
Please do whatever testing you can, as I think that this is almost ready
to go in, as long as Jelmer is OK with that (or is happy to work with
you to fix any remaining issues after it's in).
The only style point you have missed is that + should, like % be given a
space on each side:
message(GUESS, "rootdn :"+str(names.rootdn))
message(GUESS, "rootdn :" + str(names.rootdn))
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 190 bytes
Desc: This is a digitally signed message part
More information about the samba-technical