[SCM] Samba Shared Repository - branch master updated

Jelmer Vernooij jelmer at samba.org
Fri Jun 11 08:15:37 MDT 2010


Hi Matthias,

On Fri, 2010-06-11 at 03:21 -0500, Matthias Dieter Wallnöfer wrote:
> +        # proof if the DN has been set correctly
> +        res = ldb.search("cn=ldaptestgroup,cn=users," + self.base_dn,
> +                         scope=SCOPE_BASE, attrs=["distinguishedName"])
> +        self.assertTrue(len(res) == 1)
> +        self.assertTrue("distinguishedName" in res[0])
> +        self.assertTrue(Dn(ldb, res[0]["distinguishedName"][0])
> +           == Dn(ldb, "cn=ldaptestgroup, cn=users," + self.base_dn))
Just a quick hint - not something that needs fixing here but something
to keep in mind in the future. You might want to use self.assertEquals()
rather than == and self.assertTrue() since that will give more useful
error messages if the assertion fails.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100611/d68fcd6b/attachment.pgp>


More information about the samba-technical mailing list