patch for samba3 master: prevent generation of "shlib.so" file

simo idra at samba.org
Fri Jun 11 07:09:16 MDT 2010


On Fri, 2010-06-11 at 14:02 +0200, Olaf Flebbe wrote:
> Hi,
> 
> compiling s3 from master creates a file "shlib.so" (with quotes) in the
> source tree. There is an eval missing to interpret the quotes as intended.

Thanks!
I did notice it as well, and your patch fixes it.

Pushed to master.

Simo.


> Patch appended.
> 
> Cheers
>   Olaf
> differences between files attachment
> (0001-configure.in-prevent-generation-of-file-shlib.so.patch)
> >From cdc976ae1b07e1fe1053c25a748b62a7fb47c255 Mon Sep 17 00:00:00 2001
> From: Olaf Flebbe <o.flebbe at science-computing.de>
> Date: Fri, 11 Jun 2010 13:52:23 +0200
> Subject: [PATCH] configure.in prevent generation of file "shlib.so"
> 
> ---
>  source3/configure.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/source3/configure.in b/source3/configure.in
> index 71d416c..3f04136 100644
> --- a/source3/configure.in
> +++ b/source3/configure.in
> @@ -1869,7 +1869,7 @@ AC_CACHE_CHECK([whether building shared libraries actually works],
>     then
>       TESTCMD="`eval echo \"$SHLD $LDSHFLAGS $PICFLAG\"`"
>       TESTCMD="$TESTCMD -o \"shlib.$SHLIBEXT\" shlib.o"
> -     if AC_TRY_COMMAND([$TESTCMD 1>&AS_MESSAGE_LOG_FD 2>&1])
> +     if AC_TRY_COMMAND([eval $TESTCMD 1>&AS_MESSAGE_LOG_FD 2>&1])
>       then
>         ac_cv_shlib_works=yes
>       fi


-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list