[SCM] Samba Shared Repository - branch master updated

[Jelmer Vernooij]

On Mon, 2010-05-31 at 17:11 -0400, simo wrote:
> On Mon, 2010-05-31 at 22:07 +0200, Jelmer Vernooij wrote:
> > On Mon, 2010-05-31 at 13:52 -0400, simo wrote:
> > > On Mon, 2010-05-31 at 12:23 -0500, Jelmer Vernooij wrote:
> > > > The branch, master has been updated
> > > >        via  7f75ee0... ldb: Install ldb_handlers.h header.
> > > >        via  fe8302b... ldb: Remove Samba-specific symbols.
> > > >        via  1bc53f0... ldb: Move utility functions to separate file.
> > > >        via  82d56b9... ldb: Fix dependencies when building with system ldb.
> > > >       from  471ed70... s3:smbd map_username() doesn't need sconn anymore
> > > > 
> > > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > > 
> > > > 
> > > > - Log -----------------------------------------------------------------
> > > > commit 7f75ee025ff9c02763fb9201d94af4b2739c8e03
> > > > Author: Jelmer Vernooij <jelmer at samba.org>
> > > > Date:   Mon May 31 18:29:11 2010 +0200
> > > > 
> > > >     ldb: Install ldb_handlers.h header.
> > > 
> > > Jelmer,
> > > why are you installing this header ?
> > > It is a private header afaik.
> > It's used by ldb-samba, so we need the functions in there exposed somehow. Could we perhaps move them to ldb.h ?
> Does ldb-samba now build against libldb ?
> Otherwise you can directly reference the header, no ?
Yeah, it builds against the system ldb (if installed) with this header
installed.

[ building only the command-line tools against the system ldb ]
> > We supported a similar thing in the old build system but in that case we
> > always had lib/ldb/include in the include path. We don't have that in
> > the case of the waf build, and I'd like to avoid it (also to prevent
> > accidentally including ldb_private.h somewhere while we link against the
> > system ldb).
> 
> It's ok for the rest of samba, but is it problematic for the tools
> themselves.
Why ? They only rely on the public API of LDB, not on any private
symbols.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100608/00c25076/attachment.pgp>