[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Jun 7 08:34:18 MDT 2010


On Mon, Jun 07, 2010 at 03:44:47PM +0200, Volker Lendecke wrote:
> On Mon, Jun 07, 2010 at 07:51:01AM -0500, Andrew Bartlett wrote:
> > The branch, master has been updated
> >        via  00089fd... s3:auth make sure the primary group sid is usable
> >        via  048575d... s3:auth return the full passwd struct from check_account
> >        via  0a7ff14... s3:passdb Export function to calculate the proper primary group sid
> >        via  aaf45cd... s3:auth remove unused structure member
> >        via  aa1a3cb... s3:auth create nt token from info3 directly
> >        via  e6456df... s3:auth handle unix domain sids in samu
> >        via  61823fb... s3:auth set the resolved user sid in the fake sam account
> >        via  ef94217... s3:auth check the user is valid first
> >        via  1bb0afa... s3:auth make sure we set the right username
> >       from  aa32725... s4:ldap.py - add some "objectclass" behaviour tests
> 
> Please revert these changes until they are explicitly
> acknowledged by a S3 developer.

Gna, replied to the wrong commit message, thanks to Simo for
pointing that out to me. This applies to

0dc88d2..9a747d5

Please revert those. While I don't like the struct renaming,
I would be okay with them. In particular 8f1cec5 and 4a7f45b
definitely need to be reverted now, and I don't see the
point for edba46c. There is only one error condition here,
so why do we have to bother with NTSTATUS?

So please revert those three.

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100607/2308b33f/attachment-0001.pgp>


More information about the samba-technical mailing list