[PATCH] switch smbcli_open over to NTCreateAndX

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jul 28 15:48:01 MDT 2010

On Wed, Jul 28, 2010 at 01:11:32PM -0700, James Peach wrote:

> Yes, there's definitely valid arguments in both directions.

I gave my arguments, I would like to hear the argument to
stop using old calls, except to be compatible with NetApp :-)

For example, if you run thunderbird on Linux using cifsfs
against a NetApp filer, it can corrupt your mailboxes. The
reason is that NetApp does not support the variant of
ftruncate that cifsfs uses properly and cifsfs also does not
properly retry with a different version. Then somewhere on
the path into thunderbird the error code is lost, I've
forgotten exactly where that got lost. The end result is
that thunderbird under certain circumstances believes that
it has truncated a mbox file while it has not. Another
instance is cifsfs trying to list xattrs against NetApp.
A version of NetApp that I've seen sent complete garbage. 39
bytes of seemingly uninitialized memory. cifsfs did not
appreciate that.

It is a nice stream of income for me to diagnose those
problems, but if possible I would like to avoid that
behaviour on the Samba server side. That's why I would like
to continue walking as many code paths as possible in our
default test suite, insufficient as it might be currently.

> In general, I'm arguing that the default operation for
> smbtorture should be to use the modern protocol. That is,
> if the test author did not go to the trouble of
> deliberately specifying which operation to use, then it
> should use NT LM 0.12.

Just for my understanding: NT LM 0.12, doesn't that also
include the old calls? If I remember correctly, the old
documents said something about additional calls with every
new release. But I might really be wrong here.

> OK, I will hold off until I get a chance to add an
> explicit SMBOpenAndX test. I'll post for review before
> committing.



More information about the samba-technical mailing list