tdb_check fails with tdb read-only open.
Jeremy Allison
jra at samba.org
Wed Jul 28 06:10:11 MDT 2010
On Wed, Jul 28, 2010 at 09:34:33PM +1000, tridge at samba.org wrote:
> Hi Jeremy,
>
> > - if (tdb_lockall(tdb) == -1)
> > + if (tdb->read_only) {
> > + ret = tdb_lockall_read(tdb);
> > + } else {
> > + ret = tdb_lockall(tdb);
> > + }
>
> If tdb_check() doesn't need write access, then why not always use
> tdb_lockall_read(), regardless of tdb->read_only ?
Doh. That makes sense.... Modified fix to follow :-).
More information about the samba-technical
mailing list