tdb_check fails with tdb read-only open.

[tridge at samba.org]

Hi Jeremy,

 > -	if (tdb_lockall(tdb) == -1)
 > +	if (tdb->read_only) {
 > +		ret = tdb_lockall_read(tdb);
 > +	} else {
 > +		ret = tdb_lockall(tdb);
 > +	}

If tdb_check() doesn't need write access, then why not always use
tdb_lockall_read(), regardless of tdb->read_only ?

Cheers, Tridge