[PATCH] switch smbcli_open over to NTCreateAndX
Volker.Lendecke at SerNet.DE
Mon Jul 26 10:56:04 MDT 2010
On Mon, Jul 26, 2010 at 09:33:14AM -0700, James Peach wrote:
> > Everybody else uses ntcreate, so this might be a
> > little regression test for the "old" code.
> Well the end result of that argument is that smbtorture should use
> random ancient calls in unpredictable circumstances :) I counter by
> claiming that smbtorture should use the calls that are in use by real
> clients, since those are the ones that matter to users.
Well, it *does* use the modern calls in other circumstances.
I would argue pretty stronly that we keep the old calls
active. I had more than one day of bug-fixing of weird
clients against NetApp filers, because those do exactly what
you describe: They only serve the clients that are in their
supported client matrix, they don't go an inch beyond what
their clients demand. They don't act like Samba tries to
act, namely try to do everything a Windows server would do.
But that's really a matter of philosophy.
If you apply that patch, please make sure that the
corresponding call is still excercised in another test.
More information about the samba-technical