[PATCH] switch smbcli_open over to NTCreateAndX

James Peach jorgar at gmail.com
Mon Jul 26 10:33:14 MDT 2010

On 22 July 2010 22:53, Volker Lendecke <Volker.Lendecke at sernet.de> wrote:
> On Thu, Jul 22, 2010 at 09:13:04PM -0700, James Peach wrote:
>> On 19 July 2010 17:10, James Peach <jamespeach at me.com> wrote:
>> > Hi all,
>> >
>> > Just a small patch to smbtorture.
>> >
>> > Since SMBOpenAndX is deprecated, we should not be using it
>> > everywhere. Convert smbcli_open to use NTCreateAndX instead.
>> >
>> > Signed-off-by: James Peach <jpeach at samba.org>
>> Unless anyone objects, I'll merge this next week.
> I don't really "object", but I don't see why this needs to
> be done.

I had some time on my hands and decided to fix something that seemed
to me to need fixing.

> Everybody else uses ntcreate, so this might be a
> little regression test for the "old" code.

Well the end result of that argument is that smbtorture should use
random ancient calls in unpredictable circumstances :) I counter by
claiming that smbtorture should use the calls that are in use by real
clients, since those are the ones that matter to users.

James Peach | jorgar at gmail.com

More information about the samba-technical mailing list