[PATCH SET] Refactoring of auth_ntlmssp

[simo]

On Tue, 2010-07-20 at 08:09 +1000, Andrew Bartlett wrote:
> On Mon, 2010-07-19 at 14:54 -0400, simo wrote:
> > On Mon, 2010-07-19 at 16:56 +1000, Andrew Bartlett wrote:
> > > Indeed!  However, we should ensure we keep the shortest route to the
> > > solution, and don't make changes that we have to essentially reverse
> > > later on.   My hope is that if we keep this abstraction, we don't have
> > > to reintroduce it when I bring GENSEC in common.
> > 
> > The tree
> > http://git.samba.org/?p=idra/samba.git;a=shortlog;h=refs/heads/ntlmssp
> > has been updated with the other-way-around solution.
> 
> Simo,
> 
> Thankyou for your patience with me on this.  This looks like a good
> solution, and I'm happy to sign off on it (and even push it if you would
> like).

Please do.

> As I probably didn't make clear, in the future I would like to propose
> that we consolidate struct auth_ntlmssp_state with struct
> pipe_auth_data, and use this structure and a single entry point for all
> callers, on all protocols (ie, beyond DCE/RPC). 
> 
> ie, I would like to move the switch in functions like
> cli_pipe_verify_ntlmssp() into a renamed
> auth_ntlmssp_state/pipe_auth_data wrapper. 

I'll leave that to you for now.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>