[PATCH SET] Refactoring of auth_ntlmssp

Andrew Bartlett abartlet at samba.org
Mon Jul 19 16:09:11 MDT 2010

On Mon, 2010-07-19 at 14:54 -0400, simo wrote:
> On Mon, 2010-07-19 at 16:56 +1000, Andrew Bartlett wrote:
> > Indeed!  However, we should ensure we keep the shortest route to the
> > solution, and don't make changes that we have to essentially reverse
> > later on.   My hope is that if we keep this abstraction, we don't have
> > to reintroduce it when I bring GENSEC in common.
> The tree
> http://git.samba.org/?p=idra/samba.git;a=shortlog;h=refs/heads/ntlmssp
> has been updated with the other-way-around solution.


Thankyou for your patience with me on this.  This looks like a good
solution, and I'm happy to sign off on it (and even push it if you would

As I probably didn't make clear, in the future I would like to propose
that we consolidate struct auth_ntlmssp_state with struct
pipe_auth_data, and use this structure and a single entry point for all
callers, on all protocols (ie, beyond DCE/RPC). 

ie, I would like to move the switch in functions like
cli_pipe_verify_ntlmssp() into a renamed
auth_ntlmssp_state/pipe_auth_data wrapper. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100720/4f6cdeb0/attachment.pgp>

More information about the samba-technical mailing list